Median of two sorted arrays
Question: There are 2 sorted arrays A and B of size n each. Write an algorithm to find the median of the array obtained after merging the above 2 arrays(i.e. array of length 2n). The complexity should be O(log(n))
Median: In probability theory and statistics, a median is described as the number separating the higher half of a sample, a population, or a probability distribution, from the lower half.
The median of a finite list of numbers can be found by arranging all the numbers from lowest value to highest value and picking the middle one.
For getting the median of input array { 12, 11, 15, 10, 20 }, first sort the array. We get { 10, 11, 12, 15, 20 } after sorting. Median is the middle element of the sorted array which is 12.
There are different conventions to take median of an array with even number of elements, one can take the mean of the two middle values, or first middle value, or second middle value.
Let us see different methods to get the median of two sorted arrays of size n each. Since size of the set for which we are looking for median is even (2n), we are taking average of middle two numbers in all below solutions.
Method 1 (Simply count while Merging)
Use merge procedure of merge sort. Keep track of count while comparing elements of two arrays. If count becomes n(For 2n elements), we have reached the median. Take the average of the elements at indexes n-1 and n in the merged array. See the below implementation.
Implementation:
#include <stdio.h>
/* This function returns median of ar1[] and ar2[].
Assumptions in this function:
Both ar1[] and ar2[] are sorted arrays
Both have n elements */
int getMedian(int ar1[], int ar2[], int n)
{
int i = 0; /* Current index of i/p array ar1[] */
int j = 0; /* Current index of i/p array ar2[] */
int count;
int m1 = -1, m2 = -1;
/* Since there are 2n elements, median will be average
of elements at index n-1 and n in the array obtained after
merging ar1 and ar2 */
for (count = 0; count <= n; count++)
{
/*Below is to handle case where all elements of ar1[] are
smaller than smallest(or first) element of ar2[]*/
if (i == n)
{
m1 = m2;
m2 = ar2[0];
break;
}
/*Below is to handle case where all elements of ar2[] are
smaller than smallest(or first) element of ar1[]*/
else if (j == n)
{
m1 = m2;
m2 = ar1[0];
break;
}
if (ar1[i] < ar2[j])
{
m1 = m2; /* Store the prev median */
m2 = ar1[i];
i++;
}
else
{
m1 = m2; /* Store the prev median */
m2 = ar2[j];
j++;
}
}
return (m1 + m2)/2;
}
/* Driver program to test above function */
int main()
{
int ar1[] = {1, 12, 15, 26, 38};
int ar2[] = {2, 13, 17, 30, 45};
int n1 = sizeof(ar1)/sizeof(ar1[0]);
int n2 = sizeof(ar2)/sizeof(ar2[0]);
if (n1 == n2)
printf("Median is %d", getMedian(ar1, ar2, n1));
else
printf("Doesn't work for arrays of unequal size");
getchar();
return 0;
}
Time Complexity: O(n)
Method 2 (By comparing the medians of two arrays)
This method works by first getting medians of the two sorted arrays and then comparing them.
Let ar1 and ar2 be the input arrays.
Algorithm:
1) Calculate the medians m1 and m2 of the input arrays ar1[]
and ar2[] respectively.
2) If m1 and m2 both are equal then we are done.
return m1 (or m2)
3) If m1 is greater than m2, then median is present in one
of the below two subarrays.
a) From first element of ar1 to m1 (ar1[0...|_n/2_|])
b) From m2 to last element of ar2 (ar2[|_n/2_|...n-1])
4) If m2 is greater than m1, then median is present in one
of the below two subarrays.
a) From m1 to last element of ar1 (ar1[|_n/2_|...n-1])
b) From first element of ar2 to m2 (ar2[0...|_n/2_|])
5) Repeat the above process until size of both the subarrays
becomes 2.
6) If size of the two arrays is 2 then use below formula to get
the median.
Median = (max(ar1[0], ar2[0]) + min(ar1[1], ar2[1]))/2
Example:
ar1[] = {1, 12, 15, 26, 38}
ar2[] = {2, 13, 17, 30, 45}
For above two arrays m1 = 15 and m2 = 17
For the above ar1[] and ar2[], m1 is smaller than m2. So median is present in one of the following two subarrays.
[15, 26, 38] and [2, 13, 17]
Let us repeat the process for above two subarrays:
m1 = 26 m2 = 13.
m1 is greater than m2. So the subarrays become
[15, 26] and [13, 17]
Now size is 2, so median = (max(ar1[0], ar2[0]) + min(ar1[1], ar2[1]))/2
= (max(15, 13) + min(26, 17))/2
= (15 + 17)/2
= 16
Implementation:
#include<stdio.h>
int max(int, int); /* to get maximum of two integers */
int min(int, int); /* to get minimum of two integeres */
int median(int [], int); /* to get median of a sorted array */
/* This function returns median of ar1[] and ar2[].
Assumptions in this function:
Both ar1[] and ar2[] are sorted arrays
Both have n elements */
int getMedian(int ar1[], int ar2[], int n)
{
int m1; /* For median of ar1 */
int m2; /* For median of ar2 */
/* return -1 for invalid input */
if (n <= 0)
return -1;
if (n == 1)
return (ar1[0] + ar2[0])/2;
if (n == 2)
return (max(ar1[0], ar2[0]) + min(ar1[1], ar2[1])) / 2;
m1 = median(ar1, n); /* get the median of the first array */
m2 = median(ar2, n); /* get the median of the second array */
/* If medians are equal then return either m1 or m2 */
if (m1 == m2)
return m1;
/* if m1 < m2 then median must exist in ar1[m1....] and ar2[....m2] */
if (m1 < m2)
{
if (n % 2 == 0)
return getMedian(ar1 + n/2 - 1, ar2, n - n/2 +1);
else
return getMedian(ar1 + n/2, ar2, n - n/2);
}
/* if m1 > m2 then median must exist in ar1[....m1] and ar2[m2...] */
else
{
if (n % 2 == 0)
return getMedian(ar2 + n/2 - 1, ar1, n - n/2 + 1);
else
return getMedian(ar2 + n/2, ar1, n - n/2);
}
}
/* Function to get median of a sorted array */
int median(int arr[], int n)
{
if (n%2 == 0)
return (arr[n/2] + arr[n/2-1])/2;
else
return arr[n/2];
}
/* Driver program to test above function */
int main()
{
int ar1[] = {1, 2, 3, 6};
int ar2[] = {4, 6, 8, 10};
int n1 = sizeof(ar1)/sizeof(ar1[0]);
int n2 = sizeof(ar2)/sizeof(ar2[0]);
if (n1 == n2)
printf("Median is %d", getMedian(ar1, ar2, n1));
else
printf("Doesn't work for arrays of unequal size");
getchar();
return 0;
}
/* Utility functions */
int max(int x, int y)
{
return x > y? x : y;
}
int min(int x, int y)
{
return x > y? y : x;
}
Time Complexity: O(logn)
Algorithmic Paradigm: Divide and Conquer
Method 3 (By doing binary search for the median):
The basic idea is that if you are given two arrays ar1[] and ar2[] and know the length of each, you can check whether an element ar1[i] is the median in constant time. Suppose that the median is ar1[i]. Since the array is sorted, it is greater than exactly i-1 values in array ar1[]. Then if it is the median, it is also greater than exactly j = n – i – 1 elements in ar2[].
It requires constant time to check if ar2[j] <= ar1[i] <= ar2[j + 1]. If ar1[i] is not the median, then depending on whether ar1[i] is greater or less than ar2[j] and ar2[j + 1], you know that ar1[i] is either greater than or less than the median. Thus you can binary search for median in O(lg n) worst-case time.
For two arrays ar1 and ar2, first do binary search in ar1[]. If you reach at the end (left or right) of the first array and don't find median, start searching in the second array ar2[].
1) Get the middle element of ar1[] using array indexes left and right.
Let index of the middle element be i.
2) Calculate the corresponding index j of ar2[]
j = n – i – 1
3) If ar1[i] >= ar2[j] and ar1[i] <= ar2[j+1] then ar1[i] and ar2[j]
are the middle elements.
return average of ar2[j] and ar1[i]
4) If ar1[i] is greater than both ar2[j] and ar2[j+1] then
do binary search in left half (i.e., arr[left ... i-1])
5) If ar1[i] is smaller than both ar2[j] and ar2[j+1] then
do binary search in right half (i.e., arr[i+1....right])
6) If you reach at any corner of ar1[] then do binary search in ar2[]
Example:
ar1[] = {1, 5, 7, 10, 13}
ar2[] = {11, 15, 23, 30, 45}
Middle element of ar1[] is 7. Let us compare 7 with 23 and 30, since 7 smaller than both 23 and 30, move to right in ar1[]. Do binary search in {10, 13}, this step will pick 10. Now compare 10 with 15 and 23. Since 10 is smaller than both 15 and 23, again move to right. Only 13 is there in right side now. Since 13 is greater than 11 and smaller than 15, terminate here. We have got the median as 12 (average of 11 and 13)
Implementation:
#include<stdio.h>
int getMedianRec(int ar1[], int ar2[], int left, int right, int n);
/* This function returns median of ar1[] and ar2[].
Assumptions in this function:
Both ar1[] and ar2[] are sorted arrays
Both have n elements */
int getMedian(int ar1[], int ar2[], int n)
{
return getMedianRec(ar1, ar2, 0, n-1, n);
}
/* A recursive function to get the median of ar1[] and ar2[]
using binary search */
int getMedianRec(int ar1[], int ar2[], int left, int right, int n)
{
int i, j;
/* We have reached at the end (left or right) of ar1[] */
if(left > right)
return getMedianRec(ar2, ar1, 0, n-1, n);
i = (left + right)/2;
j = n - i - 1; /* Index of ar2[] */
/* Recursion terminates here.*/
if (ar1[i] > ar2[j] && (j == n-1 || ar1[i] <= ar2[j+1]))
{
/*ar1[i] is decided as median 2, now select the median 1
(element just before ar1[i] in merged array) to get the
average of both*/
if (ar2[j] > ar1[i-1] || i == 0)
return (ar1[i] + ar2[j])/2;
else
return (ar1[i] + ar1[i-1])/2;
}
/*Search in left half of ar1[]*/
else if (ar1[i] > ar2[j] && j != n-1 && ar1[i] > ar2[j+1])
return getMedianRec(ar1, ar2, left, i-1, n);
/*Search in right half of ar1[]*/
else /* ar1[i] is smaller than both ar2[j] and ar2[j+1]*/
return getMedianRec(ar1, ar2, i+1, right, n);
}
/* Driver program to test above function */
int main()
{
int ar1[] = {1, 12, 15, 26, 38};
int ar2[] = {2, 13, 17, 30, 45};
int n1 = sizeof(ar1)/sizeof(ar1[0]);
int n2 = sizeof(ar2)/sizeof(ar2[0]);
if (n1 == n2)
printf("Median is %d", getMedian(ar1, ar2, n1));
else
printf("Doesn't work for arrays of unequal size");
getchar();
return 0;
}
Time Complexity: O(logn)
Algorithmic Paradigm: Divide and Conquer
The above solutions can be optimized for the cases when all elements of one array are smaller than all elements of other array. For example, in method 3, we can change the getMedian() function to following so that these cases can be handled in O(1) time. Thanks to nutcracker for suggesting this optimization.
/* This function returns median of ar1[] and ar2[].
Assumptions in this function:
Both ar1[] and ar2[] are sorted arrays
Both have n elements */
int getMedian(int ar1[], int ar2[], int n)
{
// If all elements of array 1 are smaller then
// median is average of last element of ar1 and
// first element of ar2
if (ar1[n-1] < ar2[0])
return (ar1[n-1]+ar2[0])/2;
// If all elements of array 1 are smaller then
// median is average of first element of ar1 and
// last element of ar2
if (ar2[n-1] < ar1[0])
return (ar2[n-1]+ar1[0])/2;
return getMedianRec(ar1, ar2, 0, n-1, n);
}
References:
http://en.wikipedia.org/wiki/Median
Asked by Snehal
Please write comments if you find the above codes/algorithms incorrect, or find other ways to solve the same problem.
You may also like following posts
different lenght, iteration
/* Paste your code here (You may delete these lines if not writing code) */ #include <stdio.h> #include <stdlib.h> #include <algorithm> using namespace std; int cent(int a, int b, int c){ //a and b must be in order from small to large return min(max(a,c),b); } double findmedian(int a1[],int n1, int a2[],int n2){ int *p1, *p2; if(n1 < n2) { p1=a1; p2=a2; }else{ p1=a2; p2=a1; int tmp=n2; n2=n1; n1=tmp; } if(n1 == 1){ if(n2 == 1) return 0.5*(p1[0]+p2[0]); if(n2 == 2) return cent(p2[0],p2[1],p1[0]); //n2 >=3 ; int mid1=(n2-1)/2; int mid2= n2/2; if(mid1==mid2) return 0.5*(p2[mid1]+cent(p2[mid1-1],p2[mid1+1],p1[0])); return cent(p2[mid1],p2[mid2],p1[0]); } while(n1 > 0){ if(n1 == 2){ if(n2 == 2) return 0.5*(max(p1[0],p2[0]) + min(p1[1],p2[1])); int mid1=(n2-1)/2; int mid2= n2/2; return 0.5*( cent(p2[mid1-1],p2[mid1+1],cent(p1[0],p1[1],p2[mid1])) + cent(p2[mid2-1],p2[mid2+1],cent(p1[0],p1[1],p2[mid2]))); } int mid11=(n1-1)/2; int mid12=n1/2; int mid21=(n2-1)/2; int mid22=n2/2; if((mid11+mid12) == (mid21+mid22)) return 0.5*(mid11+mid12); else if((mid11+mid12) < (mid21+mid22)){ n1-=mid11; p1=&p1[mid11]; n2=n2-mid11; }else{ int trim=n1-mid12-1; n1=mid12+1; n2-=trim; p2=&p2[trim]; } continue; } } int main(int argc, char** argv){ int a[]={-1,1,2,3,3,7,9,11,33}; int b[]={2,4}; int n1=sizeof(a)/sizeof(int); int n2=sizeof(b)/sizeof(int); printf("Median is %f\n",findmedian(a,n1,b,n2)); }Rascala different length arrays. Do this. Mind it.
#include<stdio.h> #include<conio.h> #include<iostream.h> int max(int a,int b) { return((a>b)?a:b); } int min(int a,int b) { return((a<b)?a:b); } int median(int arr1[],int arr2[],int n1,int n2,int m1,int m2) { //Base case - Recursion end case if((n2-n1)<=1 && (m2-m1)<=1) { if((n2-n1)==1 && (m2-m1)==1) //2 elements in both sublists return(max(max(arr1[n1],arr2[m1]),min(arr1[n2],arr2[m2]))); else if((n2-n1)==0) //1st sublist just 1 element return(min(arr2[m1],arr2[m2])); else //2nd sublist contains just 1 element return(min(arr1[n1],arr1[n2])); } //Recursion step int mid1=(n1+n2)/2; int mid2=(m1+m2)/2; if(arr1[mid1]<arr2[mid2]) return(median(arr1,arr2,mid1,n2,m1,mid2)); else if(arr2[mid2]<arr1[mid1]) return(median(arr1,arr2,n1,mid1,mid2,m2)); else if(arr1[mid1]==arr2[mid2]) { if((n2-n1)>(m2-m1)) //more elements in arr1 return(arr1[mid1+1]); else if((n2-n1)<(m2-m1)) //more elements in arr2 return(arr2[mid2+1]); else return(arr1[mid1]); } } int main() { int arr1[]={4,21,34,56,78}; int arr2[]={2,34,56,57,67,89}; int n=sizeof(arr1)/sizeof(arr1[0]); int m=sizeof(arr2)/sizeof(arr2[0]); cout<<"\nMedian of merged arrays is: "<<median(arr1,arr2,0,n-1,0,m-1); getch(); return 0; }@Ajinkya:
Your solution is wrong. Try:
arr1:
41 42 43 74 83
arr2:
3 6 10 25 53 76 78 84 95
Your answer is 25
Right is number between 43 and 53
#include<stdio.h> #include<stdlib.h> #define MIN -32767 #define MAX 32767 /* this can be used to find the median of two sorted array */ int findK(int A[], int m, int B[], int n, int k) { if(m<0 || n<0 || k<0 || k >(m+n)) return -1; int i = (int)((double)m / (m+n) * (k-1)); int j = (k-1) - i; // invariant: i + j = k-1 // Note: A[-1] = -INF and A[m] = +INF to maintain invariant int Ai_1 = ((i == 0) ? MIN : A[i-1]); int Bj_1 = ((j == 0) ? MIN : B[j-1]); int Ai = ((i == m) ? MAX : A[i]); int Bj = ((j == n) ? MAX : B[j]); if (Bj_1 < Ai && Ai < Bj) return Ai; else if (Ai_1 < Bj && Bj < Ai) return Bj; // if none of the cases above, then it is either: if (Ai < Bj) // exclude Ai and below portion // exclude Bj and above portion return findK(A+i+1, m-i-1, B, j, k-i-1); else /* Bj < Ai */ // exclude Ai and above portion // exclude Bj and below portion return findK(A, i, B+j+1, n-j-1, k-j-1); } int main() { int m,n; int a[3]= {1,3,5}; int b[4]= {2,4,6,8}; m=3; n=4; if((m+n)%2==0) { int y1=findK(a,m,b,n,(m+n)/2); int y2=findK(a,m,b,n,((m+n)/2+1)); printf("Median %f",(float)(y1+y2)/(float)(2.0)); } else printf("Median %d",findK(a,m,b,n,(m+n)/2+1)); return 0; }@All: Updates on this post have been in queue from a long time. Apologies for the long delay. We have updated the post now.
@nutcracker: Thanks for suggesting the optimization. We have added a point for your suggested optimization.
@jntl: Thanks for suggesting the fix. We have incorporated your suggested changes, method 2 is now bug free.
@Anonymous and @spandan: We will soon be publishing another post for arrays of unequal size.
second solution might fail for cases where arrays are not of equal size.
The above solutions are only for two sorted arrays of equal size. We will soon be publishing another post for unequal size.
I think method -1 will fail in following case
arr1 - {1,2,3,4,5,6,7,8,9,10,14,156}
arr2 = { 2002, 2004,....}
Can you explain if it would not fail
@Nishant: You could try running the program before commenting here. Anyways, I did this for you and it worked fine. See the following program. It gives output as 1079 which is average of 156 and 2002.
#include <stdio.h> /* This function returns median of ar1[] and ar2[]. Assumptions in this function: Both ar1[] and ar2[] are sorted arrays Both have n elements */ int getMedian(int ar1[], int ar2[], int n) { int i = 0; /* Current index of i/p array ar1[] */ int j = 0; /* Current index of i/p array ar2[] */ int count; int m1 = -1, m2 = -1; /* Since there are 2n elements, median will be average of elements at index n-1 and n in the array obtained after merging ar1 and ar2 */ for(count = 0; count <= n; count++) { /*Below is to handle case where all elements of ar1[] are smaller than smallest(or first) element of ar2[]*/ if(i == n) { m1 = m2; m2 = ar2[0]; break; } /*Below is to handle case where all elements of ar2[] are smaller than smallest(or first) element of ar1[]*/ else if(j == n) { m1 = m2; m2 = ar1[0]; break; } if(ar1[i] < ar2[j]) { m1 = m2; /* Store the prev median */ m2 = ar1[i]; i++; } else { m1 = m2; /* Store the prev median */ m2 = ar2[j]; j++; } } return (m1 + m2)/2; } /* Driver program to test above function */ int main() { int ar1[] = {1,2,3,4,5,6,7,8,9,10,14,156}; int ar2[] = {2002, 2004, 2006, 2008,2010, 2012, 2014, 2016,2018, 2020, 2022, 2024}; int n = sizeof(ar1)/sizeof(ar1[0]); printf("%d", getMedian(ar1, ar2, n)) ; getchar(); return 0; }http://anandtechblog.blogspot.com/2011/06/google-interview-find-kth-smallest-from.html
Nice code!
Can you walk me through the following case:
int ar1[] = {1, 3, 5, 7};
int ar2[] = {2, 8, 10};
It seems could be find the right median.Thank you.
Hey Guys,
Curious if this would work. Tested it on a few samples n looks fine.
let A and B be the two sorted arrays.
m = length(A) n=length(B)
have two pointers ptrA and ptrB pointing to the first element of A and B respectively. if A[ptrA]<= B[ptrB], increment ptrA. else increment ptrB. stop when the number of increments is equal to (m+n)/2.
if m+n is odd, the median is the minimum( A[ptrA] and B[ptrB] ). if even take mean of the min number and next greater number.
Kindly let me know if this works!
@Zero: This method looks same as method 1. Correct me if I am wrong.
just check for ar1[0] & ar2[0]
if ar1[0] is smaller then call getMedianRec for ar1
else call getMedianRec for ar2.
int getMedian(int ar1[], int ar2[], int n) { if (ar1[n-1] < ar2[0]) return (ar1[n-1]+ar2[0])/2; if (ar2[n-1] < ar1[0]) return (ar2[n-1]+ar1[0])/2; return getMedianRec(ar1, ar2, 0, n-1, n); }/* this code looks more clean */ int getMedian(int ar1[], int ar2[], int n) { if (ar1[n-1] < ar2[0]) return (ar1[n-1]+ar2[0])/2; if (ar2[n-1] < ar1[0]) return (ar2[n-1]+ar1[0])/2; return getMedianRec(ar1, ar2, 0, n-1, n); } int getMedianRec(int ar1[], int ar2[], int left, int right, int n) { int i, j; /* We have reached at the end (left or right) of ar1[] */ if(left > right) return getMedianRec(ar2, ar1, 0, n-1, n); i = (left + right)/2; j = n - i - 1; /* Index of ar2[] */ if (i==0 || j==0) return (ar1[i]+ar2[j])/2; /* Recursion terminates here.*/ if(ar1[i] > ar2[j] && (ar1[i] <= ar2[j+1])) { return (ar1[i] + ar1[i-1])/2; } /*Search in left half of ar1[]*/ else if (ar1[i] > ar2[j] && ar1[i] > ar2[j+1]) return getMedianRec(ar1, ar2, left, i-1, n); /*Search in right half of ar1[]*/ else /* ar1[i] is smaller than both ar2[j] and ar2[j+1]*/ return getMedianRec(ar1, ar2, i+1, right, n); } /* Driver program to test above function */ int main() { // int ar1[] = {1, 12, 15, 26, 38}; // int ar2[] = {2, 13, 17, 30, 45}; int ar1[] = {1,3,5,7,11}; int ar2[] = {9,13,15,17,19}; int ar1[] = {1,3,5,7,9}; int ar2[] = {11,13,15,17,19}; printf("%d", getMedian(ar1, ar2, 5)) ; getchar(); return 0; }Yes, this check would induce another best case run of O(1). Nice !
shouldn't we first check if all elements of one array are smaller or greater than other array?
int getMedian(int ar1[], int ar2[], int n)
{
if (a[n-1] b[n-1]) return ((b[n-1]+a[0])/2);
return getMedianRec(ar1, ar2, 0, n-1, n);
}
an O(2n) algo would be
int median (int a[], int b[], int n) { int i=n-1;int j=i; While (j>=0) { if (a[i]>b[j]) { swap(a[i],b[j]);} j--; } return ((a[n-1] + b[0])/2); }that was good explanation,
I would like to know your approach when the two array have the different length.
how about doing this for sorted arrays with unequal elements.
heyy, really a very nice article!!!
very nice article.
great algorithms, elegant solutions and very good explanations!
Thanks!
Good work . Thanks for sharing your knowledge . The way your explained was simple great !!!!
IMHO, the code of Method 2 should be modified as:
if (m1 < m2) { if (n % 2 == 0) return getMedian(ar1 + n/2 - 1, ar2, n - n/2 +1); else return getMedian(ar1 + n/2, ar2, n - n/2); } if (n % 2 == 0) return getMedian(ar2 + n/2 - 1, ar1, n - n/2 + 1); else return getMedian(ar2 + n/2, ar1, n - n/2);In Method 2, consider the following test case:
arr1[]={2, 4, 6, 10}
arr2[]={1, 3, 9, 12}
Method 1 returns (4 + 6 ) / 2 = 5, which is correct.
Method 2 returns (3 + 6) / 2 = 4, which is wrong!
This is because Method 2 picks {6, 10} from arr1 and {1, 3} from arr2, which will lost the correct pair {4, 6}.
We should pick {4, 6, 10} from arr1 and {1, 3, 9} from arr2 instead.
The algorithm of Method 2 should be modified as below:
if (m1 m2 case.
if we take array a[(n/2-1).....],a[.......(n/2+1)]
if n is even than it gives correct answer for this case also
In the code, interger division is used, so the median of 1 and 4 is (1 + 4) / 2 = 2
I think it is better to use float division so that the median is 2.5, which is more precise.
@Rohini: In the above algorithms/codes, it is assumed that arrays are of equal size, but can be easily modified for the arrays of different sizes.
Does this work for 2 different sizes of the sorted array?
@rv_10987: Thanks very much for pointing out this case. We have made changes to handle it. For median of a single array arr[], we have added a function median() that returns appropriate median.
In method 2:
Test case: arr1[]={2,4,6,8}
arr2[]={1,3,6,9}
n=4
As m1=arr1[n/2]=6 and m2=arr2[n/2]=6 so the o/p would be 6. But the median should be (4+6)/2=5.
@Ved, instead of passing the reduced array, you may use the lower index and higher index that bound the reduced array.
So, instead of just passing the Array1, Array2
Pass low1, high1 and low2 and high2 along with Array1 and Array2.
So, mid1 = (low1+high1)/2 and mid2=(low2+high2)/2
The method 2 (Median of Median) using recursion is very good for languages where we can pass an array with an offset.
I am not able to translate the same logic in Java where I can not pass the reduced array for each recursive call.
Any ideas ?
@sachin midha: Thanks very much for pointing out the bug. We have included the suggested changes to the original post.
I didnot run the program so i dont know whether it gives correct result or not but what i thought was this :
for the ex. that you have given with
ar1[] = {1, 2, 3, 4, 6}
count & i in the called function are each 0 initially
after pass 1 : i=1 & count=1
after pass 2 : i=2 & count=2
after pass 3 : i=3 & count=3
after pass 4 : i=4 & count=4
after pass 5 : i=5 & count=5
now since count=5 the loop will run again and will compare
ar1[5] with ar2[0] but since ar1[5] is not a legitimate element, it is conceptually wrong.(Its a WARNING:ARRAY bounds crossed but not an error but it runs)
In your case, you might be getting the correct answer because the random element ar1[5] was by chance greater than ar2[0].
Although it is a very small bug but i thought to bring it up so that i may get to know if there is some problem in my evaluation.
and this problem can be eradicated by putting an if at the start of the loop before comparison of
ar1[i] & ar2[j].
if(i==n) { m1=m2; m2=ar2[0]; break; } else if(j==n) { m1=m2; m2=ar1[0]; break; }I hope im clear enough this time.
@sachin midha: Could you please provide example arrays for which the method 1 didn't work. We tried below for method 1 and got the correct answer.
/* Driver program to test method 1 */ int main() { int ar1[] = {1, 2, 3, 4, 6}; int ar2[] = {10, 13, 17, 30, 45}; printf("%d", getMedian(ar1, ar2, 5)) ; getchar(); return 0; }In method 1, one case has not been taken care of,i.e.,
if all the elements of one array are smaller than all the elements of the oher array.
In this case suppose elements of arr1 are less than the first element of arr2, then when count = n index of arr1 which will be accessed, will be arr1[n] which is not an existing element, hence generating an error.
Similarly when all arr2 elements are smaller arr2[n] would be accessed which is again an error condition.
@Minjie Zha: Thanks very much for pointing out the typo. We have corrected it.
Step (5) in method 3, there is a typo. I think it should be "smaller" instead of "greater".
I think this article made some interesting points, I read a textbook directly related to this topic, its called Probability: Theory and Examples by Richard Durrett , I found my used copy for less than the bookstores at http://www.belabooks.com/books/9780534424411.htm
Thanks a lot ...The Best part of the solution is the way of explaining ...